search

atom / language-perl

Perl package for Atom
Other
25 stars 32 forks source link

Disable escape in single quote #25

Closed Fank closed 9 years ago

Fank commented 9 years ago

This fixes #22 quote_highlighting

winstliu commented 9 years ago

This isn't strictly related to your changes, but as far as I know, the Atom team loves to have tests flow naturally, eg it "does not escape characters in single-quote strings" instead of it "'text'".

Fank commented 9 years ago

Thanks for the info ill update it

Fank commented 9 years ago

@50Wliu Now its more naturally or?

winstliu commented 9 years ago

Other than some minor notes, great job! describes look like they might also need some work but I'm less clear on the rules for those. Maybe @kevinsawicki can clarify?

Fank commented 9 years ago

@50Wliu Thanks for all the comments, i changed all it.

kevinsawicki commented 9 years ago

@kevinsawicki can clarify?

Yeah, here is an example of the typical spec flow:

describe "when tokenizing constant variables", ->
  it "creates tokens with the constant scope", ->

So basically when you combine the describe and the it, it flows like a natural sentence: "when tokenizing constant variables it creates tokens with the constant scope". These kind of combined sentences are what is shown in the spec window or command line when they fail.

You might want to look at this core spec for more examples: https://github.com/atom/atom/blob/587ebd753840517dca899982d6a4f3931a1f1b39/spec/text-editor-spec.coffee#L21-L22

I'm okay merging this now though, thanks for fixing this.