search

atom / language-perl

Perl package for Atom
Other
25 stars 32 forks source link

Add an "impossible" rule to Perl's __END__ pattern #66

Closed Alhadis closed 8 years ago

Alhadis commented 8 years ago

While Atom permits the omission of a range pattern's "end" rule, not all engines using TextMate's rendering engine do, including TextMate itself. For example, this rule is ignored by the Lightshow app when previewing a piece of Perl code containing freeform text following an END line.

Admittedly, this is a pretty minor issue, since I only just noticed GitHub's syntax highlighting is unaffected by this (Lightshow's probably using an older version of First-Mate, or whatever's powering the rendering). But I only noticed this after I'd made the almost-completely-useless fix, so... eh... :')

Alhadis commented 8 years ago

To all the watchers who just received an e-mail notifying them about an almost meaningless pull request, I'd like to profusely apologise.

Fank commented 8 years ago

Could you please include tests for it?

Alhadis commented 8 years ago

Sure thing! :D One sec.

Alhadis commented 8 years ago

And by "one sec", I mean "17 minutes". Oops.

Sorry, I get a bit paranoid about getting TDD-related stuff right... :|

Fank commented 8 years ago

LGTM /CC @atom/feedback

lee-dohm commented 8 years ago

Thanks @Alhadis for contributing!

Alhadis commented 8 years ago

No wuckin' furries, as we say here in Australia. =)