search

atom / language-perl

Perl package for Atom
Other
25 stars 32 forks source link

Adding a basic support for perl6. #9

Closed ashgti closed 9 years ago

ashgti commented 9 years ago

Adding some basic support for Perl6. This is not complete, it only has basic support for variable matching and doesn't match sub/method/etc. names yet, but it does match keywords, builtins and a number of primitives of perl6.

ashgti commented 9 years ago

I removed the change to the version number. Let me know if you have any other comments. I am working on a more in-depth grammar for Perl 6 but this is has basic support for most literals and keywords.

pchaigno commented 9 years ago

Is there anything else that needs to be done to merge this?

Fank commented 9 years ago

Some test might by nice, but looks fine to me

ashgti commented 9 years ago

@Fank I am working on creating a more detailed grammar for perl6 and it will include test cases as well.

kevinsawicki commented 9 years ago

@Fank are you cool with me merging this? Or did you have any other feedback before it gets merged?

Fank commented 9 years ago

@kevinsawicki yea you can merge this

kevinsawicki commented 9 years ago

Thanks for this @ashgti

kraih commented 9 years ago

Perl6 is an entirely different language than Perl5, it should really have its own package.

Fank commented 9 years ago

@kraih Perl 6 is still a member of the Perl familiy. And its handled in different files https://github.com/atom/language-perl/tree/master/grammars to avoid collisions. And increases the maintainability to handle multiple versions in the same package.

kraih commented 9 years ago

@Fank Like C# is in the C family of languages. Both grammars don't share anything, how does having them in the same package increase maintainability?

Fank commented 9 years ago

@kraih i thought it maybe better to add all "perl" versions in the "perl" package so you can manage/find them easier, because all of them are in the perl package. But i took a look at the Perl 6 syntax, to compare Perl 5 with 6, and yea you might be right, because both share about <5%. @kevinsawicki, @ashgti What do you think about @kraih idea about moving Perl 6 in a different package?

kevinsawicki commented 9 years ago

I think having both of these grammars in the same package is fine, many packages contain multiple grammars that represent a cohesive grouping.

ashgti commented 9 years ago

I am fine either way, if it seems to disjoint to have in the perl repo then someone (I?) can make a separate language-perl6 repository.