Update specs for first-mate changes

atom / language-perl

Perl package for Atom

Other

25 stars 32 forks source link

Closed winstliu closed 7 years ago

winstliu commented 7 years ago

Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
All new code requires tests to ensure against regressions

Newlines are no longer guaranteed to exist on first-mate@7.0.9+. Don't try to match them and don't test for them in specs.

/cc @Fank

winstliu commented 7 years ago

:green_heart:

Alhadis commented 7 years ago

And uh...I missed one by accident. Forgot to re-test specs locally before pushing

Isn't there an emoji that says that too?

winstliu commented 7 years ago

I was actually on the Trusty branch which didn't have these changes :P. Mixed things up, promptly realized, and deleted my comment.

Alhadis commented 7 years ago

Maybe we need a broken :green_heart: emoji for these situations. 😄

winstliu commented 7 years ago

:broken_heart: :(