atom / language-php

PHP package for Atom
Other
119 stars 119 forks source link

PHP markdown bug with MySQL query inside a string combined with a single grave accent #361

Open alexr00 opened 5 years ago

alexr00 commented 5 years ago

Copied from https://github.com/microsoft/vscode/issues/74909

Using textmate grammar:

An image is worth a thousand words

<?php
    $query = 'SELECT * FROM `';
    //
    //
    $two = 'my_table` WHERE my_column=0';
    // fixed
?>
Arcanemagus commented 5 years ago

Reproduced in Atom v1.40.0-nightly1 with language-php v0.44.1: image

Note that this is likely the same issue as https://github.com/atom/language-php/issues/336, however this is using the ` character instead of '.

Arcanemagus commented 5 years ago

@Krinkle your issue is being tracked in https://github.com/atom/language-php/issues/333 (as it looks like you already found).