search

atom / language-puppet

Puppet package for Atom
Other
36 stars 31 forks source link

Fix grammar for file type #33

Closed petems closed 8 years ago

petems commented 8 years ago

Since file was defined as a constant for the ensure => file pattern, it would incorrectly highlight the file resource.

winstliu commented 8 years ago

Can you elaborate on what the problem is? I'm not sure I understand and how this fixes it.

petems commented 8 years ago

Sure, basically file resources are being mismatched:

screenshot 2016-03-12 21 36 19

It should be coloured as a regular resource:

screenshot 2016-03-12 21 37 41

After this patch:

screenshot 2016-03-12 21 41 10
winstliu commented 8 years ago

Ok. And can the bracket be on a newline following file?

winstliu commented 8 years ago

@petems: Heads up: your two remaining PRs are both conflicted.

petems commented 8 years ago

Rebased :+1:

winstliu commented 8 years ago

Any chance you can answer my question?

Can the bracket be on a newline following file?

petems commented 8 years ago

@50Wliu The curly brace cannot be on a newline

winstliu commented 8 years ago

As per the other PR where negative lookaheads were involved, can you please move them to the end of the match?

petems commented 8 years ago

@50Wliu Done! :+1: