Closed alexjurkiewicz closed 8 years ago
There's still some work to do supporting different data types as default values.
If someone can help me out with:
I don't think this fix is totally correct. Specifically, I call the type definition a
string.quoted.single.puppet
because it gives a different colour, but I don't really understand the significance of doing so, or how I'd get a dedicated name.I think it might be nice for the type to be uncoloured (like the equals sign), but not sure.
I will update the commits and then this PR should be mergable
I think it might be nice for the type to be uncoloured (like the equals sign), but not sure.
That is up to each syntax theme to interpret.
This will also need specs.
Hey, how can I run the specs locally?
EDIT: atom --test spec/puppet-spec.coffee
Think I got it! And added some specs for parameters too, since those were missing :)
No spaces around the brackets in the specs file, please.
updated
alrighty, should be good now
Thanks!
Awesome thanks!
Fixes #36 Fixes #37
I don't think this fix is totally correct. Specifically, I call the type definition a
string.quoted.single.puppet
because it gives a different colour, but I don't really understand the significance of doing so, or how I'd get a dedicated name.I think it might be nice for the type to be uncoloured (like the equals sign), but not sure.
Before:
After: