atom / language-puppet

Puppet package for Atom
Other
36 stars 31 forks source link

Parameter typing and comments #38

Closed alexjurkiewicz closed 8 years ago

alexjurkiewicz commented 8 years ago

Fixes #36 Fixes #37

I don't think this fix is totally correct. Specifically, I call the type definition a string.quoted.single.puppet because it gives a different colour, but I don't really understand the significance of doing so, or how I'd get a dedicated name.

I think it might be nice for the type to be uncoloured (like the equals sign), but not sure.

Before:

screen shot 2016-08-04 at 12 27 05 pm

After:

screen shot 2016-08-04 at 12 26 32 pm
alexjurkiewicz commented 8 years ago

There's still some work to do supporting different data types as default values.

alexjurkiewicz commented 8 years ago

If someone can help me out with:

I don't think this fix is totally correct. Specifically, I call the type definition a string.quoted.single.puppet because it gives a different colour, but I don't really understand the significance of doing so, or how I'd get a dedicated name.

I think it might be nice for the type to be uncoloured (like the equals sign), but not sure.

I will update the commits and then this PR should be mergable

winstliu commented 8 years ago

I think it might be nice for the type to be uncoloured (like the equals sign), but not sure.

That is up to each syntax theme to interpret.

This will also need specs.

alexjurkiewicz commented 8 years ago

Hey, how can I run the specs locally?

EDIT: atom --test spec/puppet-spec.coffee

alexjurkiewicz commented 8 years ago

Think I got it! And added some specs for parameters too, since those were missing :)

winstliu commented 8 years ago

No spaces around the brackets in the specs file, please.

alexjurkiewicz commented 8 years ago

updated

alexjurkiewicz commented 8 years ago

alrighty, should be good now

winstliu commented 8 years ago

Thanks!

Jinkxed commented 8 years ago

Awesome thanks!