atom / language-puppet

Puppet package for Atom
Other
36 stars 31 forks source link

Fix function calls inside parametrized classes #49

Closed mmolnar closed 7 years ago

mmolnar commented 7 years ago

Function call inside parametrized class definition breakes syntax.

This is used mainly when using hiera or lookup functions for default parameters.

50Wliu commented 7 years ago

Furthermore: Can you please show a before/after picture of this change? And if you're feeling up to it, can you please try adding specs for this change?

mmolnar commented 7 years ago

Here is the highlighting before: before It clearly does not recognize strings inside function call or anything after the function call.

And here it is after the change: after

Also I did the requested changes for the pull request. I don't know how to do specs yet so I might do them if I have more free time, but right now it would take me too much time to do.

50Wliu commented 7 years ago

Thanks!