broken highlighting for constants and support functions

[jhaals]

Constants

false|true|running|present|absent|file|directory

Support functions

escape|gsub|alert|crit|debug|notice|defined|emerg|err|failed|file|generate|include|info|realize|search|tag|tagged|template|warning

[jacobbednarz]

@JHaals I can see these are defined and the regex is just the words wrapped in a word boundary so it should be applying correctly. Could you perhaps provide a little more context around this one?

I can't see any obvious stand outs but I do use a pretty minimal theme so perhaps that is a also a factor here.

[jacobbednarz]

Just FYI, tested with a little snippet from the Puppet Docs for a random test.

class myservice($ensure = 'running') {

  if $ensure in [ running, stopped ] {
    $_ensure = $ensure
  } else {
    fail('ensure parameter must be running or stopped')
  }

  case $::operatingsystem {
    centos: {
      $package_list = 'openssh-server'
    }
    solaris: {
      $package_list = [ SUNWsshr, SUNWsshu ]
    }
    default: {
      fail("Module ${module_name} does not support ${::operatingsystem}")
    }
  }

  $variable = 'something'

  Package { ensure => present, }

  File { owner => '0', group => '0', mode => '0644' }

  package { $package_list: }

  file { "/tmp/${variable}":
    ensure => present,
  }

  service { 'myservice':
    ensure    => $_ensure,
    hasstatus => true,
  }
}

[jhaals]

Just compare the Github styling above with this screenshot: https://www.dropbox.com/s/ey60dwtnple73dy/syntax.png

[jacobbednarz]

From my testing this one appears to be working nicely for me after applying #8.

However trying on my version of Solarized Dark there are still some of them not highlighting correctly so if you don't mind @JHaals, could you please double check this?

To fix this I moved constant.language.puppet into the same block as support.function.puppet (along with adding a couple new keywords) but I am not 100% sure of all the repercussions of doing this so if @kevinsawicki has some time I might just run this by him also to be sure I am not going to accidently break everything.

Doesn't matter too much but I also found keyword.operator.assignment.php and meta.array.php were listed instead of Puppet.