PEP 515: Underscores in numeric literals

redfast00 commented 6 years ago

Prerequisites

[X] Put an X between the brackets on this line if you have done all of the following:
- Reproduced the problem in Safe Mode: http://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
- Followed all applicable steps in the debugging guide: http://flight-manual.atom.io/hacking-atom/sections/debugging/
- Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
- Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
- Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description

Numbers like 100_000_000 aren't properly highlighted (see PEP 515 specification). This should be pretty easy to fix, just edit these lines in the grammar. I tried to fix this myself, but wasn't able to get atom dev running.

Steps to Reproduce

Put 10_000_000 in source code.

Expected behavior: Proper highlighting

Actual behavior: Number highlighting stops in the middle of the number

Reproduces how often: 100%

Versions

Atom    : 1.23.3
Electron: 1.6.15
Chrome  : 56.0.2924.87
Node    : 7.4.0

winstliu commented 6 years ago

I tried to fix this myself, but wasn't able to get atom dev running.

Please ping me in the Slack channel or on Discuss and I'll help you out. I'm @Wliu on both.

Alexey-T commented 5 years ago

Why isn’t it fixed yet? Easy to do

kac487 commented 3 years ago

Are there any updates on this one?

winstliu commented 3 years ago

@kac487 do you know if this is happening with the Tree Sitter grammar, or just the non-Tree Sitter one? (If you don't know, that's fine)

kac487 commented 3 years ago

Sorry, I don't know which one it is.

atom / language-python