search

atom / language-python

Python package for Atom
Other
191 stars 147 forks source link

Please remove snippet config for 'self' #267

Closed AmyShackles closed 5 years ago

AmyShackles commented 6 years ago

Fixes #261 Fixes #154

Description of the Change

I removed this snippet:

'.source.python:not(.string)':
  'self':
    'prefix': '.'
    'body': 'self.'

-->

Alternate Designs

I considered retooling the snippet so that there was still a way for 'self' to be auto-populated in some fashion, but ultimately reasoned that the time saved from not having to type four characters is not worth the time lost having it populated accidentally.

Benefits

People will be more likely to use Atom to write their Python scrips. With the current code, 'self' is injected at almost every use of '.' Which, as you can imagine, becomes burdensome, especially since it also applies to text written in comments.

Possible Drawbacks

Some people may be using this feature and they may be annoyed to see it go.

I personally believe that more people would welcome the change than be irritated by the change.

j2bbayle commented 6 years ago

Solves #154 as well.

daviwil commented 5 years ago

Thanks @AmyShackles! Agreed, better to remove this for now since it's highly disruptive. If someone can come up with a working alternative for the removed snippet, we'll be happy to accept a PR.