Scope built in functions as support.function

Ben3eeE commented 5 years ago

Requirements

Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
All new code requires tests to ensure against regressions

Description of the Change

Scopes built in python functions as support.function. Textmate scoped these as support.function.builtin.python.

https://github.com/atom/language-python/issues/286 reported that print is no longer scoped as keyword.other. Textmate always scoped print and exec as keyword.other even when they were used as a function. In Python 3 these keywords were removed and print and exec are built in functions.

This PR fixes https://github.com/atom/language-python/issues/286 by scoping all built in functions as support.function.

Function list taken from https://docs.python.org/3/library/functions.html

Alternate Designs

Don't scope built in functions separately
Incorrectly scope print and exec as a keyword to match textmate

Benefits

Built in functions are scoped the same as textmate
Correctly scopes print and exec as functions except when used as a keyword (python2)

Applicable Issues

Fixes https://github.com/atom/language-python/issues/286

/cc: @maxbrunsfeld

maxbrunsfeld commented 5 years ago

Do the newlines in the regex affect anything?

Ben3eeE commented 5 years ago

Yeah, it makes the names around newlines not work :bear:

winstliu commented 5 years ago

What about multiline ''' strings?

Ben3eeE commented 5 years ago

Couldn't get multiline strings to work.

maxbrunsfeld commented 5 years ago

What about multiline ''' strings?

I think that syntax will remove the leading whitespace from each line of the string, but there will still be a newline in there.

atom / language-python