atom / language-python

Python package for Atom
Other
190 stars 146 forks source link

Type annotations break function arguments coloration #312

Closed Hellzed closed 3 years ago

Hellzed commented 4 years ago

Prerequisites

Description

With tree sitter enabled, adding type annotations to function arguments breaks argument coloration. image image

Steps to Reproduce

Add type annotations to a function argument

Expected behaviour:

Argument coloration should remain the same with or without a type annotation.

Actual behavior:

Argument coloration disappears, the argument is now of default text colour.

Reproduces how often:

Always.

Versions

Atom : 1.41.0 Electron: 4.2.7 Chrome : 69.0.3497.128 Node : 10.11.0 apm 2.4.3 npm 6.2.0 node 10.2.1 x64 atom 1.41.0 python 2.7.17rc1 git 2.20.1

darangi commented 4 years ago

@Hellzed Thanks!

This seems to be fixed by https://github.com/atom/language-python/pull/228#event-1441527974, the team will look into this.