search

atom / language-python

Python package for Atom
Other
190 stars 146 forks source link

Update tree-sitter-python + Add missing tree-sitter scopes #325

Closed aminya closed 3 years ago

aminya commented 3 years ago

Description of the Change

This updates tree-sitter python dependency.

Benefits

Bug fixes: https://github.com/tree-sitter/tree-sitter-python/compare/v0.15.1...v0.17.0

Applicable Issues

Solves some of the open issues regarding syntax highlighting.

Fixes https://github.com/atom/language-python/issues/324 Fixes https://github.com/atom/language-python/issues/134 Fixes https://github.com/atom/language-python/issues/273 Fixes https://github.com/atom/language-python/issues/312

Allows removing the Kite's workaround for tree-sitter: https://github.com/kiteco/atom-plugin/pull/704

aminya commented 3 years ago

@sadick254 @darangi Please take a look.

chbk commented 3 years ago

As a heads-up, #313 also fixes the missing scopes mentioned here. That said, it's part of a larger ecosystem of PRs that might take time to (hopefully) get merged, so I'm glad to see this fixed now.

aminya commented 3 years ago

As a heads-up, #313 also fixes the missing scopes mentioned here. That said, it's part of a larger ecosystem of PRs that might take time to (hopefully) get merged, so I'm glad to see this fixed now.

Thanks for the PR. I only need a few of these commits in my PR so I can close many things here and there. If you can rebase after me, that would be great.

cc: @sadick254

ThatXliner commented 3 years ago

What’s the status on this? Because once this is merged, kite should also merge the “remove workaround” (a.k.a. Stop it nagging me). Then I get to enjoy performing :atom: atom 😎

aminya commented 3 years ago

This is ready to go. We are awaiting one of the maintainers to merge this. @sadick254 @darangi

ThatXliner commented 3 years ago

@jeff-hykin (the reviewer)

jeff-hykin commented 3 years ago

@ThatXliner Not sure why I'm reviewer, but I added a review 😁

darangi commented 3 years ago

Thanks @aminya , We will look into this

darangi commented 3 years ago

@aminya could you resolve this conflict so I merge this in? Thanks for your contributions 🙇🏾

aminya commented 3 years ago

Thank you! The conflict was only the deleted travis file.

jeff-hykin commented 3 years ago

(😬 I was cleaning out my notifications and realized I commented "but I added a review" without clicking "submit" on my review)

aminya commented 3 years ago

Thanks for the review. Do you want to make a PR to fix these?

jeff-hykin commented 3 years ago

The first comment should probably be a PR, although that edgecase bug I'm describing probably happens other places too. Its a really common bug with a very very small edgecase. The other comment was just clarification.