search

atom / language-ruby-on-rails

Ruby on Rails package for Atom
Other
48 stars 41 forks source link

Update render snippets #26

Closed joseramonc closed 9 years ago

joseramonc commented 10 years ago

They weren't working for me on rails 4+, and also creates the <%= %> tags to match lt snippet that creates those tags

rubemz commented 9 years ago

hmm wouldn't this assume that erb is being used as template language? that's not always the case

mnquintana commented 9 years ago

I agree with @rubemz - the Rails snippets shouldn't assume ERB is being used for templates, since they could be any number of things (Haml, Slim, etc).

kevinsawicki commented 9 years ago

Closing this out for now, these seem to be worth having for erb snippets, please comment if you decide to update this pull request further.