search

atom / language-ruby-on-rails

Ruby on Rails package for Atom
Other
48 stars 41 forks source link

Rails ERB scope name #45

Open ricardograca opened 8 years ago

ricardograca commented 8 years ago

I know it's not working, but shouldn't the scope name be text.html.rails instead of text.html.ruby? The latter makes it seem like it's myfile.html.rb, and it doesn't match the grammar's "pretty" name: HTML (Rails).

Also, I'd like to add that the name "HTML (Rails)" isn't very accurate as well, since in this case it only refers to ERB files and Rails can use other templating engines which would still be "HTML (Rails)". That name should also be changed to something like HTML (Rails - ERB) for better consistency with the regular ERB syntax "HTML (Ruby - ERB)", and to convey the fact that it's Rails specific.

joseramonc commented 5 years ago

I'm not sure where to ask this, but I usually get confused by this package, because it does very similar things to language-ruby, but on a different way, for example: both packages having their own grammar for .erb files HTML (Rails - ERB) and HTML (Ruby - ERB) but parsed/highlighted differently; the same is true for .rb files.

Wouldn't make more sense to give up on this package or at least give up on those duplicate grammars previously mentioned to avoid confusion?

As atom doesn't support every framework for every language. I think letting atom team focus only on ruby syntax via language-ruby-package and letting specific things into community packages (like haml ) would be the optimal. But I might be missing something