search

atom / language-ruby-on-rails

Ruby on Rails package for Atom
Other
48 stars 41 forks source link

Zero not highlighted correctly #47

Closed aried3r closed 8 years ago

aried3r commented 8 years ago

screen shot 2016-09-19 at 16 54 55

All other numbers are highlighted correctly (depending on what you think is 'correct' for negative ones).

winstliu commented 8 years ago

I believe this will been fixed starting with Atom 1.11.0. Thanks for reporting though!

aried3r commented 8 years ago

This problem persists in Atom 1.11.1.

winstliu commented 8 years ago

Sorry, that was a typo. I meant 1.12.0, and this can be verified as it is listed in the 1.12-beta changelog.

aried3r commented 8 years ago

Oh, guess that's why I didn't find any mention of it. Thanks!

I guess you mean this one: https://github.com/atom/language-ruby/pull/163

winstliu commented 8 years ago

Yep! This language package inherits from language-ruby.