atom / language-ruby

Ruby package for Atom

Other

101 stars 144 forks source link

Fix missing scopes on separators and `self`, differentiate `->` #224

Closed chbk closed 3 years ago

chbk commented 6 years ago

Description of the Change

Added a separators entry to the repository
Rewrote the grammar for class and module declarations with begin/end patterns:
- Included separators
- Renamed punctuation.separator.inheritance.ruby to punctuation.separator.namespace.ruby for consistency
- Changed entity.name.type.class.ruby, entity.name.type.module.ruby and entity.other.inherited-class.module.ruby to start with an uppercase letter and to exclude separators
This is now scoped properly:
```
class A::B::C < ::D::E
```
```
class << A::B
```
```
module A::B::C
```
Scoped commas in function declarations:
```
def method(a, b)
```
Scoped self and separators in function declarations:
```
class A
    def self.method
```
Unfortunately, I wasn't able to rewrite the grammar for function declarations with begin/end patterns. I used existing regular expressions to capture separators. Since the captures are placed inside repetition patterns ()*, only the last separator will be scoped. Not perfect, but still an improvement.
Changed scopes for ->: support.function.kernel.arrow.ruby
Added specs

Applicable Issues

221 Missing scope on commas

222 Differentiate `->` from other keywords

223 Namespace separator `::` not scoped in class definition

Interdictor commented 6 years ago

Please review and approve this!

chbk commented 6 years ago

@50Wliu I have a commit pending for punctuation.separator.delimiter, is my suggestion okay to you?

winstliu commented 6 years ago

Yes, I think what you're saying is fine.

chbk commented 6 years ago

@50Wliu Do you have any other comments on this pull request? It looks ready to merge for me.

rsese commented 6 years ago

Sorry for the delay @chbk, someone from the team will take a look as soon as they can.

darangi commented 3 years ago

Thanks for the contribution 🙇🏾 @chbk