Syntax highlighting in code after beginning of Heredoc - Githubissues

atom / language-ruby

Ruby package for Atom

Other

101 stars 144 forks source link

Syntax highlighting in code after beginning of Heredoc #232

Closed fanfilmu closed 6 years ago

fanfilmu commented 6 years ago

Prerequisites

[X] Put an X between the brackets on this line if you have done all of the following:
- Reproduced the problem in Safe Mode: http://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
- Followed all applicable steps in the debugging guide: http://flight-manual.atom.io/hacking-atom/sections/debugging/
- Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
- Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
- Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description

I found room for small improvement related to heredocs in Ruby:

zrzut ekranu 2018-05-17 o 10 58 40

This is valid Ruby code and it would be awesome if ) if should_execute? would be still colored as Ruby.

I imagine it might be quite hard to do since it's in the middle of heredoc in a way, but still, something I noticed I thought I could share :)

rsese commented 6 years ago

Thanks for contributing!

I think this is a duplicate of https://github.com/atom/language-ruby/issues/75 so you can subscribe there if you'd like. If you think it's a different issue though, let me know :v:

Because we treat our issues list as the Atom team's backlog, we close duplicates to focus our work and not have to touch the same chunk of code for the same reason multiple times. This is also why we may mark something as duplicate that isn't an exact duplicate but is closely related.

For information on how to use GitHub's search feature to find out if something is a duplicate before filing, see the How Can I Contribute? section of the Atom CONTRIBUTING guide.