search

atom / language-ruby

Ruby package for Atom
Other
101 stars 144 forks source link

Add ERB highlighting inside of script tags #240

Closed jrectenwald closed 3 years ago

jrectenwald commented 6 years ago

Description of the Change

This adds embedded js rules to the grammar for html.erb files so that erb syntax highlighting will work inside of script tags.

Alternate Designs

None

Benefits

ERB highlighting will work correctly when placed inside of a script tag.

Before: before

After after

Possible Drawbacks

None that I am aware of

Applicable Issues

192 and #230

darangi commented 3 years ago

Thanks for the contribution

jrectenwald commented 3 years ago

Thanks for the contribution

Thanks for the review!