YARD comments no longer syntax highlighted

ioquatix commented 5 years ago

Prerequisites

[ ] Put an X between the brackets on this line if you have done all of the following:
- Reproduced the problem in Safe Mode: http://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
- Followed all applicable steps in the debugging guide: http://flight-manual.atom.io/hacking-atom/sections/debugging/
- Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
- Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
- Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description

Steps to Reproduce

Previously, comments would be highlighted:

# @return [String] The result
def foobar
  return "foobar"
end

Expected behavior:

@return would be highlighted, along with other parts of the structured comment.

Actual behavior:

It's not highlighted

Reproduces how often: 100%

Versions

1.32.0

ioquatix commented 5 years ago

cc @madleech

ioquatix commented 5 years ago

Here is an example of what it used to look like:

https://github.com/atom/language-ruby/issues/228

Arcanemagus commented 5 years ago

Can you please update this issue to follow the template? Thanks!

ioquatix commented 5 years ago

@Arcanemagus Okay, done. What more information do you need?

Arcanemagus commented 5 years ago

It looks like this is a regression from the enabling of Tree-sitter parsers by default in Atom v1.32.0:

Text-mate:

Tree-sitter:

You can work around this for now by changing the Settings -> Core -> Use Tree-sitter Parsers option within the Settings app.

ioquatix commented 5 years ago

Ah so maybe a bug with the new parser? or a bug with how the grammar is specified?

Arcanemagus commented 5 years ago

From what I can see that extension simply hasn't been implemented in the Tree-sitter parser.

ioquatix commented 5 years ago

That makes sense. Should we file a bug report on the tree-sitter parser?

Arcanemagus commented 5 years ago

That makes sense. Should we file a bug report on the tree-sitter parser?

Just here is fine 😉.

epaulet commented 5 years ago

It looks like the same issue may have also broken the language-todo package.

Before:

After:

Arcanemagus commented 5 years ago

@epaulet That is being tracked in https://github.com/atom/language-todo/issues/82 and https://github.com/atom/atom/issues/18196. You may want to subscribe to those issues for updates.

atom / language-ruby