search

atom / language-ruby

Ruby package for Atom
Other
100 stars 144 forks source link

Treating Heredocs as a code line rather than a String line #264

Closed Souravgoswami closed 5 years ago

Souravgoswami commented 5 years ago

In Atom, while writing a Ruby program, the delimiting identifier of heredocs is treated as a string, rather than a code. As a result the limit string is highlighted in green! This could be quite confusing 😕

So for example 📸

This is how it looks in Atom ⚛️

image

This is how it should look (ignore the black / dark look) ✨

image

(http://graysoftinc.com/ruby-voodoo/working-with-multiline-strings)

So, the EOF shouldn't be highlighted in green, how about treating it like a code rather than a String?

calebmeyer commented 5 years ago

Thanks for reaching out!

We require the template to be filled out on all new issues and pull requests. We do this so that we can be certain we have all the information we need to address your submission efficiently. This allows the maintainers to spend more time fixing bugs, implementing enhancements, and reviewing and merging pull requests.

Thanks for understanding and meeting us half way 😀