atom / language-ruby

Ruby package for Atom
Other
101 stars 144 forks source link

Inconsistent highlighting of constants #265

Closed mcandre closed 5 years ago

mcandre commented 5 years ago

Prerequisites

Description

The syntax highlighter gets confused and highlights source code content incorrectly.

Steps to Reproduce

Write a Rakefile like this:

VERSION = '0.0.1'
PROVIDER = 'virtualbox'
BOX_NAMESPACE = 'mcandre'

BOX_BASENAME = 'mucus'
BOX_BASENAME_MIPS64EL = "#{BOX_BASENAME}-mips64el"
BOX_BASENAME_MIPSEL = "#{BOX_BASENAME}-mipsel"
BOX_BASENAME_S390X = "#{BOX_BASENAME}-s390x"

BOX_MIPS64EL = "#{BOX_BASENAME_MIPS64EL}.box"
BOX_MIPSEL = "#{BOX_BASENAME_MIPSEL}.box"
BOX_S390X = "#{BOX_BASENAME_S390X}.box"

Expected behavior:

language-ruby highlights all bindings with one color, all raw string content with another color.

Actual behavior:

language-ruby highlights bindings inconsistently, and also highlights raw string content inconsistently.

Edit by @rsese: scopes screenshot with 1.40.0-nightly23 on macOS 10.14.

ruby-scopes

Reproduces how often:

Always.

Versions

Atom v1.38.2

apm  2.1.7
npm  6.2.0
node 8.9.3 x64
atom 1.38.2
python 2.7.16
git 2.20.1

Host: Ubuntu 19.04 Disco Dingo amd64

rsese commented 5 years ago

Thanks for the report and the example code :bow: Reproduced with 1.40.0-nightly23 on macOS 10.14.

ruby-scopes