atom / language-ruby

Ruby package for Atom
Other
100 stars 144 forks source link

Tree Sitter doesn't highlight public/private/protected #268

Closed swrobel closed 5 years ago

swrobel commented 5 years ago

Prerequisites

Description

public/private/protected keywords should be highlighted, but they are not

Steps to Reproduce

Open a Ruby source file with the following code:

class Test
  public
  private
  protected
end

(note that github highlights correctly)

Expected behavior:

With tree-sitter parsers disabled:

Screen Shot 2019-07-29 at 6 31 06 PM

Actual behavior:

With tree-sitter parsers enabled:

Screen Shot 2019-07-29 at 6 31 24 PM

Reproduces how often:

100%

Versions

Atom : 1.40.0-beta1 Electron: 3.1.10 Chrome : 66.0.3359.181 Node : 10.2.0 apm 2.4.2 npm 6.2.0 node 10.2.1 x64 atom 1.40.0-beta1 python 2.7.10 git 2.22.0

macOS 10.14.6

rsese commented 5 years ago

Thanks for the report! Reproduced on 1.39.1 on macOS 10.14 - Tree-sitter:

ruby-treesitter

Tree-sitter disabled:

ruby-firstmate