atom / language-ruby

Ruby package for Atom
Other
100 stars 144 forks source link

Symbol literals have incorrect class #270

Closed npezza93 closed 5 years ago

npezza93 commented 5 years ago

Prerequisites

Description

Symbol literals have the syntax--constant syntax--other classes attached to them and are thus highlighted as constants which is incorrect. They should be highlighted like symbols and have syntax--constant syntax--other syntax--symbol classes.

Steps to Reproduce

  1. Type the following in a ruby file:
    %i(thing) 
    %I(thing #{thing})
    :thing 
  2. Notice all instances of thing on the first two lines are a different color than the last thing instance.

Expected behavior:

All instances of thing should be the same color.

Actual behavior:

They are a different color.

Reproduces how often:

100%

Versions

macOS Mojave atom 1.42.0-nightly0

rsese commented 5 years ago

Thanks @npezza93 - reproduced on macOS 10.14.6 with 1.42.0-nightly1:

ruby-constants

jasonrudolph commented 5 years ago

I've opened https://github.com/atom/language-ruby/pull/271 to fix this issue.

jasonrudolph commented 5 years ago

This is now fixed on Atom's master branch, and it will be available in on the Atom Nightly channel tomorrow.

Thanks for the bug report, @npezza93. :bow: Also, I see on your profile that you're in Durham. :wave: Hello from another Atom+Ruby fan in Durham! Small world. 😄

npezza93 commented 5 years ago

Awesome, thanks @jasonrudolph! Nice to meet another fellow Durham+Atom+Rubyist! 👋