atom / language-ruby

Ruby package for Atom
Other
101 stars 145 forks source link

Inconsistency in Ruby symbol with TreeSitter #275

Closed foreverqihe closed 5 years ago

foreverqihe commented 5 years ago

Prerequisites

Description

Steps to Reproduce

  1. Open a ruby file, e.g. test.rb
  2. write:
%i[a b c]
:abc

Expected behavior:

The 2 lines of code are both symbols, so they should be the same color.

Actual behavior:

The first line is orange/yellow. But if I turn off the TreeSitter, they are in the same color.

Reproduces how often:

Always

Versions

C:\Windows\System32>atom --version

Atom : 1.40.1 Electron: 3.1.10 Chrome : 66.0.3359.181 Node : 10.2.0

Additional Information

C:\Windows\System32>apm --version apm 2.4.3 npm 6.2.0 node 10.2.1 x64 atom 1.40.1 python 3.7.0 git 2.18.0.windows.1 visual studio

foreverqihe commented 5 years ago

Expected color: image

The actual color image

rsese commented 5 years ago

Thanks for the report! I believe this was fixed in https://github.com/atom/language-ruby/pull/271 - with 1.40.1 I can reproduce what you describe:

ruby-tree-sitter-1 40 1

But with 1.42.0-nightly6 I see:

ruby-tree-sitter-1 42 0-nightly6

Going to go ahead and close as a duplicate of https://github.com/atom/language-ruby/issues/270 but if I misunderstood anything, please let me know.