search

atom / language-sass

Sass package for Atom
Other
62 stars 58 forks source link

meta.selector missing (provided by CSS though.) #29

Open envygeeks opened 9 years ago

envygeeks commented 9 years ago

When working on a syntax theme I noticed that Less does provide meta.selector for tag {} like CSS, can we please get this so that we can provide consistency across multiple different kinds of CSS source types.

50Wliu commented 8 years ago

Hi @envygeeks, can you please provide a code block with comments that shows where meta.selector should be? Thanks.

envygeeks commented 8 years ago

Hey @50Wliu here is an example

div:target {
  hello:world
}

"div:target" is `meta.selector.css" in CSS and wraps around the entity. I still don't fully comprehend the CSON files that make up language files but here it is in CSS: https://github.com/atom/language-css/blob/master/grammars/css.cson#L476-L479 the problem with SCSS is that we have no generic wrapper around said selectors.

envygeeks commented 8 years ago

Why I originally wanted this, I can't remember, but looking at the source of my personal theme, I'm to assume it was because of a bug somewhere that prevented entity.name.tag from being applied to the "div" which prevented me from matching the theme in all sources, it could have also just as well been a choice to optimize my CSS because I had no need to highlight unique pieces and add more LESS than necessary. It could have also been just because I was slightly annoyed at an inconsistency. Ultimately though, re-reviewing, it seems to imply to me I asked for it because of a bug I didn't know was a bug that seems to have been addressed upstream in Core or in another place, because all types (LESS/CSS) highlight properly but SCSS doesn't which implies to me I couldn't find a workaround.

As it stands right now though, I see no problem other than consistency... not one that I can't fix within the next few minutes by reworking my themes LESS at least.

While I would still like to see the consistency, there is no urgency IMO.