DATETIME not being tokenized/grouped

atom / language-sql

SQL package for Atom

Other

38 stars 54 forks source link

Closed smaili closed 8 years ago

smaili commented 8 years ago

datetime

50Wliu commented 8 years ago

@smaili What do you think it should be tokenized as? (Not familiar with SQL at all, hence the question)

smaili commented 8 years ago

storage type sql

50Wliu commented 8 years ago

I can't reproduce this using Atom 1.3.0-dev-69dfdd0 - can you try again on at least v1.1.0 @smaili? Thanks.

smaili commented 8 years ago

@50Wliu Still not tokenizing in 1.1.0.

50Wliu commented 8 years ago

Ah hah-looks like Atom is still using v0.17.0 of language-sql on 1.1.0 (https://github.com/atom/atom/blob/stable/package.json#L143), while datetime was added in v0.18.0. Sorry! As a workaround you can try using 1.2.0-beta0.

smaili commented 8 years ago

Good catch :+1: