Extend DROP keyword; add ADD keyword

atom / language-sql

SQL package for Atom

Other

38 stars 50 forks source link

Extend DROP keyword; add ADD keyword #33

Closed caleb531 closed 8 years ago

caleb531 commented 8 years ago

Hi,

I've been using this package for a Databases class I'm taking, and it's proven quite useful (and aesthetically pleasing, naturally). However, I've noticed the package doesn't seem to highlight valid statements like ADD FOREIGN KEY and DROP CONSTRAINT.

Since this is a relatively simple issue to fix, I took the liberty of adding and extending the appropriate grammar rules. Please review my pull request for exactly what was added; I'd be happy to make any changes if need be.

Thanks, Caleb

winstliu commented 8 years ago

Hi @caleb531, thanks for this! Is there any chance you can try adding specs to cover this change? If you need help here are some more advanced spec files from other grammars: language-javascript, language-c

caleb531 commented 8 years ago

Thanks, @50Wliu, though given the existing grammar tests, writing the new tests for ADD and DROP seemed fairly straightforward. I've pushed up the revised spec now—let me know if it's to your liking. :)

winstliu commented 8 years ago

:+1: