search

atom / language-sql

SQL package for Atom
Other
38 stars 50 forks source link

Tokenize UNIQUE modifier #46

Closed caleb531 closed 7 years ago

caleb531 commented 7 years ago

Hi,

I recently discovered that the grammar for this package does not tokenize the SQL UNIQUE keyword. It's a standard SQL modifier (like PRIMARY KEY), so I think it should be tokenized.

I believe I've added everything required (including a passing unit test), but please let me know if you have any concerns or changes to request.

Before:

screen shot 2016-10-26 at 9 09 23 pm

After:

screen shot 2016-10-26 at 9 09 55 pm

Thanks, Caleb

torkelrogstad commented 7 years ago

Although reading this issue gives me the impression this is fixed, UNIQUE is still not highlighted in my editor. Might I have done something wrong, or is this issue still not fixed?

screen shot 2016-11-16 at 13 42 46

50Wliu commented 7 years ago

It was merged but not included in the latest release. Current ETA is Atom 1.14.0.