atom / language-sql

SQL package for Atom
Other
38 stars 50 forks source link

Clean up comment regexes #64

Closed winstliu closed 7 years ago

winstliu commented 7 years ago

Requirements

Description of the Change

They were overly complicated and causing bugs such as https://github.com/atom/language-php/issues/187. Simplify them.

Alternate Designs

None.

Benefits

Easier to understand, less conflicts with other rules due to the removal of the ^ start-of-line match.

Possible Drawbacks

None.

Applicable Issues

Fixes atom/language-php#187

Gonkers commented 7 years ago

Fantastic! Thank you.