atom / language-sql

SQL package for Atom
Other
38 stars 50 forks source link

IF token mis-highlighted for CREATE TABLE IF NOT EXISTS... statements #79

Closed mcandre closed 5 years ago

mcandre commented 5 years ago

IF inside of CREATE TABLE IF NOT EXISTS... is highlighted incorrectly. It should be the same keyword color as the rest of these tokens, but instead language-sql is highlighting as if IF were the table name.

See https://dev.mysql.com/doc/refman/5.7/en/create-table.html

rsese commented 5 years ago

Hmm, this is what I see in Atom 1.37.0 on macOS 10.12.6 (I grabbed a full example from StackOverflow):

sql-if-not-exists

Going to close since I can't reproduce but if you have more information or I'm misunderstanding, please let me know.

Filling out the template would have been really helpful here - for example:

I think we've mentioned this before but for future issues, please fill out the issue template - the template provides useful baseline information for us when looking at issues. Issues without the template filled out may be closed at the discretion of whichever maintainer is triaging your issue.