search

atom / language-sql

SQL package for Atom
Other
38 stars 50 forks source link

SIGNED, UNSIGNED keywords not highlighted #83

Open mcandre opened 4 years ago

mcandre commented 4 years ago

The SIGNED and UNSIGNED keywords for declaring fine numeric types, such as in MySQL, are not being highlighted.

https://dev.mysql.com/doc/refman/5.7/en/numeric-type-overview.html

rsese commented 4 years ago

Doesn't seem to mention specifically in that reference but seems like a non-standard extension? Do you have a sense about whether this conflicts with any other SQL dialects?

Arcanemagus commented 4 years ago

It doesn't match the SQL2016 standard, PostgreSQL, Transact-SQL, or Oracle, however the worst case for supporting it though is that if somebody types that and is expecting a more standards compliant view they may not get an indication from Atom itself that their code is wrong.