search

atom / language-todo

TODO highlighting package for Atom
Other
80 stars 66 forks source link

Add elixir snippet support #43

Open keathley opened 8 years ago

keathley commented 8 years ago

Adding elixir scope for snippets.

winstliu commented 8 years ago

@atom/feedback Similar to atom/one-dark-syntax#67, are we not accepting PRs that add functionality for packages that aren't included with Atom by default?

thomasjo commented 8 years ago

@50Wliu I agree; we should not add special support for packages that are not bundled with Atom.

lee-dohm commented 8 years ago

I'm going to talk with the team and figure out what our policy is around this kind of thing.

simurai commented 8 years ago

FYI: https://github.com/atom/one-dark-syntax/pull/67 is a wontfix (for now). But suggesting that everyone has to add support for non-bundled languages themselves isn't ideal and we should definitely think about a better long term solution.

keathley commented 8 years ago

Thanks for looking into this everyone. It looked like other non-bundled languages were being supported by this package (scala, and typescript) which is why I made the initial PR. This has also been the pattern I've seen in other packages such as atom/bracket-matcher.

That said, it seems like having to add specific scopes to all of these external packages isn't a maintainable solution long term (which I assume is the conclusion that y'all have come to as well). It also creates inconsistencies that users attribute to the specific language package.

I'm not sure that I have a better idea of how to manage this yet but I'd be happy to discuss it or try a few things out.