search

atom / language-typescript

TypeScript language package for Atom
Other
21 stars 33 forks source link

Support for Styled Components? #10

Closed phyllisstein closed 6 years ago

phyllisstein commented 6 years ago

The language-babel package for Atom includes special highlighting rules that support Styled Components, highlighting tagged template literals starting with styled as CSS:

screenshot

Are there any plans for similar support in language-typescript? What would the path to that kind of support look like? Happy to try for a PR if there's a wish for it.

damieng commented 6 years ago

I want to make sure this package doesn't diverge from the upstream work it is based on as the maintenance cost goes right up.

If this could be done without modifying the existing two grammar files we get from the upstream repository (maintained by Microsoft) then we might consider it.

phyllisstein commented 6 years ago

That makes total sense. Thanks for responding so quickly and thoughtfully! I'll try playing around a little and see if there's anything that can be done.

zaynv commented 6 years ago

Is it still not possible to add support for this? I see that VSCode seems to have support for this