search

atom / language-typescript

TypeScript language package for Atom
Other
21 stars 33 forks source link

Add proper commenting for jsx #13

Closed taylon closed 6 years ago

taylon commented 6 years ago

Comments in JSX should be handled differently, this PR fixes that.

damieng commented 6 years ago

Thanks for your contribution.

These files are a copy from the upstream source https://github.com/Microsoft/TypeScript-TmLanguage and we don't want to get out of step as it makes taking changes from upstream more painful.

I would recommend you send a PR to that repository to fix it there so that all repositories that base their grammar on there get the improvement including this one!

Thanks!

taylon commented 6 years ago

Are settings also copied from there? I might be missing something, but I looked at it and it seems to only provide the grammar, I could not find anything related to snippets or settings...

damieng commented 6 years ago

Sorry yes, you are right these are snippets not grammar!