atom / language-typescript

TypeScript language package for Atom
Other
21 stars 33 forks source link

Multiline arguments types invalid highlight #32

Closed qwelias closed 5 years ago

qwelias commented 5 years ago

Prerequisites

Description

Multiline arguments types highlited as variables in arrow functions

Steps to Reproduce

Type an arrow function with typed multiline arguments.

Expected behavior: Correct highlight

Actual behavior: Sample

Reproduces how often: 100%

Versions

Atom : 1.34.0 Electron: 3.1.3 Chrome : 66.0.3359.181 Node : 10.2.0

rsese commented 5 years ago

Thanks for the report! I'm unable to reproduce with 1.34.0 on macOS 10.12.6 (I'm using One Dark syntax theme):

ts-highlighting

Do you have Tree-sitter disabled (Settings > Core > Enable Tree Sitter Parsers)?

rsese commented 5 years ago

Ugh sorry, second time I've missed this recently :smile:

Atom : 1.34.0 Electron: 3.1.3

In the official stable 1.34.0 release, we're on Electron 2.0.16 - so based on your version details, we've determined that you are currently using an unofficial build or distribution of Atom. Often these customized versions of Atom are modified versions of the Stable branch of Atom with mismatched versions of built-in components. These updated components are taken from the Beta channel or master branch and then injected into the Stable version and a new Atom package is generated. Because of the way Atom is constructed, using these mismatched components can cause mysterious and hard-to-diagnose problems. You can find out more about why we chose to not support unofficial distributions here.

You can find instructions for installing an official version of Atom in the Flight Manual. If you are still seeing this problem on an official build please file a new issue, thanks!