Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
All new code requires tests to ensure against regressions
Description of the Change
The previous numeric implementation was custom-written and seems to combine YAML's spec with a bit of Java's. This rewrite makes it conform to the official YAML spec at http://www.yaml.org/spec/1.2/spec.html#id2805071. Some changes include:
Removal of support for 3.0f-style floats
Removal of support for 0X2-style hexadecimal integers (0x2 is still supported)
Octal support
Positive/number integer/float support
Infinity/NaN support
Alternate Designs
Keep the existing implementation but tweak it to support the additions listed above. I rejected this because it wouldn't conform to YAML.
Requirements
Description of the Change
The previous numeric implementation was custom-written and seems to combine YAML's spec with a bit of Java's. This rewrite makes it conform to the official YAML spec at http://www.yaml.org/spec/1.2/spec.html#id2805071. Some changes include:
3.0f-style floats0X2-style hexadecimal integers (0x2is still supported)Alternate Designs
Keep the existing implementation but tweak it to support the additions listed above. I rejected this because it wouldn't conform to YAML.
Benefits
See above additions.
Possible Drawbacks
See above removals.
Applicable Issues
Fixes #102