search

atom / line-ending-selector

Switch between Unix and Window style line endings.
MIT License
33 stars 18 forks source link

More friendly EOL description #14

Closed bluebruce closed 7 years ago

bluebruce commented 9 years ago

It will be more user friendly to add "Windows" or "Unix" description on both UI and convert menu. For example, change: LF to Unix(LF) CRLF to Windows(CRLF) CR to Old Mac(CR)

GuillaumeLegendre commented 8 years ago

Maybe add the sentence character too \r\n or \n or...

edit: I mean in the part who appear after we click on the LF in the status bar

lee-dohm commented 8 years ago

I feel like status-bar space is at a premium. Perhaps changing the text in the selection menu and then adding a tooltip for when hovering over the control in the status bar?

GuillaumeLegendre commented 8 years ago

Exactly like I expect it in better. My english didn't allow me to explain it well.

bronson commented 7 years ago

Would https://github.com/atom/line-ending-selector/pull/42 address this issue?

(assuming we can agree on wording...)

bluebruce commented 7 years ago

@bronson Great solution! Works without taking status-bar space.

bronson commented 7 years ago

Well, it's not merged yet... But I admire your confidence. :)

bluebruce commented 7 years ago

OK. then I wait. :) Will github notify me when merged? (I'm a newbie).

bronson commented 7 years ago

If I included Fixes #14 in the commit message, github would automatically close this issue and notify you when the PR is merged.

But I wasn't sure so I didn't include it.

You can subscribe to the pull request if you want to watch its progress. Or I'll comment here when it's merged or rejected.

bronson commented 7 years ago

I said I'd comment but I'm sure you've already seen that this is merged and closed @bluebruce. Thanks @damieng!