This pull request adds a test for the bug fixed in 2ff4ee3f83.
Normally, I prefer to add the test first and then fix the bug second. We were in a bit of a time crunch to get https://github.com/atom/line-ending-selector/pull/46 shipped, so I committed the bug fix in that PR, and I'm following up with this PR to add the corresponding test.
It's probably easier to review this PR's individual commits than it is to review the consolidated diff. For example, f5ea7d0574f32b0df1932b7e047e87be96844ff9 refactors the existing tests to make room for adding a new test related to the bug. Then, ed3da092e0d0e57108cf5000435b84a1e3c75945 adds the new test related to the bug.
Alternate Designs
N/A
Benefits
We're less likely to accidentally re-introduce the bug fixed in 2ff4ee3f83.
Description of the Change
This pull request adds a test for the bug fixed in 2ff4ee3f83.
Normally, I prefer to add the test first and then fix the bug second. We were in a bit of a time crunch to get https://github.com/atom/line-ending-selector/pull/46 shipped, so I committed the bug fix in that PR, and I'm following up with this PR to add the corresponding test.
It's probably easier to review this PR's individual commits than it is to review the consolidated diff. For example, f5ea7d0574f32b0df1932b7e047e87be96844ff9 refactors the existing tests to make room for adding a new test related to the bug. Then, ed3da092e0d0e57108cf5000435b84a1e3c75945 adds the new test related to the bug.
Alternate Designs
N/A
Benefits
We're less likely to accidentally re-introduce the bug fixed in 2ff4ee3f83.
Possible Drawbacks
N/A
Applicable Issues
https://github.com/atom/line-ending-selector/pull/46