Upgrade prebuild-install to v7.0.1

atom / node-keytar

Native Password Node Module

https://atom.github.io/node-keytar

MIT License

1.37k stars 193 forks source link

Upgrade prebuild-install to v7.0.1 #443

Closed sergiou87 closed 2 years ago

sergiou87 commented 2 years ago

Supersedes #441

joaomoreno commented 2 years ago

@sergiou87 Isn't prebuild-install meant to be a runtime dependency? That's the only way you can have dependants download binary assets at keytar installation time.

sergiou87 commented 2 years ago

You are absolutely right @joaomoreno, I got carried away by https://github.com/atom/node-keytar/issues/438#issuecomment-1026159950 and made the change, I'll revert that. Thanks!

joaomoreno commented 2 years ago

Thanks a bunch for getting on top of this @sergiou87!