search

atom / node-keytar

Native Password Node Module
https://atom.github.io/node-keytar
MIT License
1.37k stars 193 forks source link

Added support for armv7l arch (Raspberry Pi 32bit) #446

Closed nzapponi closed 2 years ago

nzapponi commented 2 years ago

Requirements for Adding, Changing, or Removing a Feature

Issue or RFC Endorsed by Atom's Maintainers

401

Description of the Change

Added support for prebuilt binaries for 32 bit ARM architecture. This is useful when compiling Electron apps that are supposed to also work on Raspberry Pi (most userlands are 32 bit there).

Alternate Designs

Not having a prebuilt binary means that every app needs to be compiled on a separate machine, which is painful.

Possible Drawbacks

None that I can think of

Verification Process

Release Notes

nzapponi commented 2 years ago

@sergiou87 would you mind taking a look at this when you have a minute please?

sergiou87 commented 2 years ago

Yes, sorry! It's all looking good, let's see if CI gives us all 🟢

sergiou87 commented 2 years ago

@nzapponi seems like it's not finding libsecret https://github.com/atom/node-keytar/runs/5143792435?check_suite_focus=true#step:13:3989 😞

nzapponi commented 2 years ago

Whoops, sorry, my bad. Let me fix that

nzapponi commented 2 years ago

This should do it @sergiou87

nzapponi commented 2 years ago

@sergiou87 do you have any plans to release a new version including this PR anytime soon? Thanks!

sergiou87 commented 2 years ago

No plans, but I will do one soon (hopefully this week). We're kind of busy with GitHub Desktop releases at the moment, sorry, but I will let you know 😄

sergiou87 commented 2 years ago

@nzapponi 7.9.0 should be ready and include armv7l binaries 😄 Please let me know if that works

nzapponi commented 2 years ago

That's awesome, thank you!!