Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
Ensure the variable secret is not NULL before passing it to the function secret_value_get_text.
Alternate Designs
An alternate design could be to use a GCancellable object in secret_service_search_sync function call. I tried to use it but failed to understand how to use it.
Possible Drawbacks
This MR should not add a possible drawback.
Verification Process
Test suite still pass (npm run test).
Using FindCredentials without unlocking my keystore in my electron app does not crash anymore.
Requirements for Contributing a Bug Fix
Identify the Bug
https://github.com/atom/node-keytar/issues/477
Description of the Change
Ensure the variable
secret
is not NULL before passing it to the functionsecret_value_get_text
.Alternate Designs
An alternate design could be to use a
GCancellable
object insecret_service_search_sync
function call. I tried to use it but failed to understand how to use it.Possible Drawbacks
This MR should not add a possible drawback.
Verification Process
Test suite still pass (
npm run test
). UsingFindCredentials
without unlocking my keystore in my electron app does not crash anymore.The error I got during my usage was:
Release Notes
Fixed a bug where calling
FindCredentials
without unlocking the keystore on Linux.