atom / node-oniguruma

Oniguruma Node Module
http://atom.github.io/node-oniguruma
MIT License
121 stars 46 forks source link

VS path is hardcoded? #76

Closed MikhailArkhipov closed 6 years ago

MikhailArkhipov commented 6 years ago

npm install oniguruma

Building the projects in this solution one at a time. To enable parallel build, please add the "/m" switch.

~\node_modules\oniguruma\build\oniguruma.vcxproj(20,3): 
error MSB4019: The imported project "C:\Program Files (x86)\Microsoft VisualStudio\Preview
\Enterprise\Common7\IDE\VC\VCTargets\Microsoft.Cpp.Default.props" was not found. 
Confirm that the path in the <Import> declaration is correct, 
and that the file exists on disk.

VS 2017 has multiple installs (I have 3). You can try and use https://github.com/Microsoft/vswhere for the location

thomasjo commented 6 years ago

Nothing is hard-coded. This is an upstream problem in node-gyp. Either install VS2015, or ensure you have recent version of npm (5.x or newer). Further details can be found in the upstream issue comments.