fix compile errors on NodeJS 12

atom / node-oniguruma

Oniguruma Node Module

http://atom.github.io/node-oniguruma

MIT License

121 stars 46 forks source link

fix compile errors on NodeJS 12 #93

Closed felixhao28 closed 5 years ago

felixhao28 commented 5 years ago

Fix #92

rafeca commented 5 years ago

Thanks for the PR @felixhao28 !

grunt is not necessary on this repo (the Readme instructions were obsolete 😅 ).

I've updated your PR to remove the grunt dependencies and remove the Node v4 builds on Travis (since they don't pass).

Once the CI builds pass, I'll merge this PR and publish a new version of the package

felixhao28 commented 5 years ago

@rafeca @alexandrudima when I update this dependency of microsoft/vscode-textmate from 7.0.0 to 7.2.0, one test breaks. I have yet to find out the real cause behind it. This blocks microsoft/vscode-textmate from running on Node 12.