search

atom / node-pathwatcher

Path Watcher Node Module
http://atom.github.io/node-pathwatcher
MIT License
93 stars 47 forks source link

Also test compilation on Node 0.10 #91

Closed winstliu closed 9 years ago

winstliu commented 9 years ago

Accidentally pushed this to master... :fearful: :disappointed:.

Refs 9d8cec25a263a17395052225cba78ab768ce4b9b

winstliu commented 9 years ago

The last spec fails because Node 0.10 uses a version of V8 that's too old to support Promises. Is it worth supporting Node 0.10 since it's 1) over two years old, and 2) superseded by 0.12, iojs 1, 2, 3, and Node 4?

zcbenz commented 9 years ago

I think we should keep this module compiling on Node 0.10 since there are still many people using it to listen to filesystem events, but it should be fine to ignore the File and Directory things since I think only Atom is using them and keeping them compatible with 0.10 is too much work.

We can probably either ignore 0.10 in Travis CI or suppress File and Directory specs for 0.10, either way is fine to me.

winstliu commented 9 years ago

In that case let's just ignore 0.10.