search

atom / node-spellchecker

SpellChecker Node Module
http://atom.github.io/node-spellchecker
MIT License
298 stars 106 forks source link

Update package.json to fix nan error #110

Open crazywolf132 opened 5 years ago

crazywolf132 commented 5 years ago

Removes the nan error.

../../nan/nan_maybe_43_inl.h:112:15: error: no member named 'ForceSet' in 'v8::Object'
  return obj->ForceSet(isolate->GetCurrentContext(), key, value, attribs);
shiftkey commented 5 years ago

@crazywolf132 which version of Node/Electron are you seeing this error on?

crazywolf132 commented 5 years ago

Hahahaha, i cant even remember what project this was for. It was that long ago i moved on.

crazywolf132 commented 5 years ago

It should have been the latest of both though.

But i remember it was another module causing it. The only fix was to update this module to the latest Nan.

It was even discussed on a stack overflow if i remember correctly. They were saying to go into this module and edit its package.json, so others wouldn't freak out. So i thought why not just push the fix to you guys.

Then no one has to mess around with anything.

goddessfreya commented 4 years ago

We are now on 0.24, so should be safe to close.