search

atom / node-spellchecker

SpellChecker Node Module
http://atom.github.io/node-spellchecker
MIT License
300 stars 108 forks source link

Unable to compile for electron@5.0.0-beta.5 #112

Open RomanKiyashev1 opened 5 years ago

RomanKiyashev1 commented 5 years ago

electron-rebuild output:

cated: Use maybe version [-Wdeprecated-declarations]
    return scope.Escape(New(persistentHandle)->Get(key));
                                               ^
/Users/romankiyashev/.electron-gyp/5.0.0-beta.5/include/node/v8.h:3313:3: note: 'Get' has been explicitly marked deprecated here
  V8_DEPRECATE_SOON("Use maybe version", Local<Value> Get(Local<Value> key));
  ^
/Users/romankiyashev/.electron-gyp/5.0.0-beta.5/include/node/v8config.h:322:29: note: expanded from macro 'V8_DEPRECATE_SOON'
  declarator __attribute__((deprecated(message)))
                            ^
In file included from ../src/main.cc:3:
../../nan/nan.h:1847:48: warning: 'Get' is deprecated: Use maybe version [-Wdeprecated-declarations]
    return scope.Escape(New(persistentHandle)->Get(index));
                                               ^
/Users/romankiyashev/.electron-gyp/5.0.0-beta.5/include/node/v8.h:3317:3: note: 'Get' has been explicitly marked deprecated here
  V8_DEPRECATE_SOON("Use maybe version", Local<Value> Get(uint32_t index));
  ^
/Users/romankiyashev/.electron-gyp/5.0.0-beta.5/include/node/v8config.h:322:29: note: expanded from macro 'V8_DEPRECATE_SOON'
  declarator __attribute__((deprecated(message)))
                            ^
In file included from ../src/main.cc:3:
In file included from ../../nan/nan.h:2657:
../../nan/nan_object_wrap.h:24:25: warning: 'IsNearDeath' is deprecated: Garbage collection internal state should not be relied on. [-Wdeprecated-declarations]
    assert(persistent().IsNearDeath());
                        ^
/Users/romankiyashev/.electron-gyp/5.0.0-beta.5/include/node/v8.h:571:3: note: 'IsNearDeath' has been explicitly marked deprecated here
  V8_DEPRECATE_SOON(
  ^
/Users/romankiyashev/.electron-gyp/5.0.0-beta.5/include/node/v8config.h:322:29: note: expanded from macro 'V8_DEPRECATE_SOON'
  declarator __attribute__((deprecated(message)))
                            ^
In file included from ../src/main.cc:3:
In file included from ../../nan/nan.h:2657:
../../nan/nan_object_wrap.h:67:18: warning: 'MarkIndependent' is deprecated: Objects are always considered independent. Use MarkActive to avoid collecting otherwise dead weak handles. [-Wdeprecated-declarations]
    persistent().MarkIndependent();
                 ^
/Users/romankiyashev/.electron-gyp/5.0.0-beta.5/include/node/v8.h:553:3: note: 'MarkIndependent' has been explicitly marked deprecated here
  V8_DEPRECATE_SOON(
  ^
/Users/romankiyashev/.electron-gyp/5.0.0-beta.5/include/node/v8config.h:322:29: note: expanded from macro 'V8_DEPRECATE_SOON'
  declarator __attribute__((deprecated(message)))
                            ^
In file included from ../src/main.cc:3:
In file included from ../../nan/nan.h:2657:
../../nan/nan_object_wrap.h:124:26: warning: 'IsNearDeath' is deprecated: Garbage collection internal state should not be relied on. [-Wdeprecated-declarations]
    assert(wrap->handle_.IsNearDeath());
                         ^
/Users/romankiyashev/.electron-gyp/5.0.0-beta.5/include/node/v8.h:571:3: note: 'IsNearDeath' has been explicitly marked deprecated here
  V8_DEPRECATE_SOON(
  ^
/Users/romankiyashev/.electron-gyp/5.0.0-beta.5/include/node/v8config.h:322:29: note: expanded from macro 'V8_DEPRECATE_SOON'
  declarator __attribute__((deprecated(message)))
                            ^
../src/main.cc:195:20: error: no template named 'Handle'
  static void Init(Handle<Object> exports) {
                   ^
../src/main.cc:61:5: error: use of undeclared identifier 'Handle'; did you mean 'handle'?
    Handle<String> string = Handle<String>::Cast(info[0]);
    ^~~~~~
    handle
../../nan/nan_object_wrap.h:42:32: note: 'handle' declared here
  inline v8::Local<v8::Object> handle() const {
                               ^
../src/main.cc:61:5: error: call to non-static member function without an object argument
    Handle<String> string = Handle<String>::Cast(info[0]);
    ^~~~~~
../src/main.cc:61:12: error: 'String' does not refer to a value
    Handle<String> string = Handle<String>::Cast(info[0]);
           ^
/Users/romankiyashev/.electron-gyp/5.0.0-beta.5/include/node/v8.h:2536:17: note: declared here
class V8_EXPORT String : public Name {
                ^
../src/main.cc:61:20: error: use of undeclared identifier 'string'
    Handle<String> string = Handle<String>::Cast(info[0]);
                   ^
../src/main.cc:61:36: error: 'String' does not refer to a value
    Handle<String> string = Handle<String>::Cast(info[0]);
                                   ^
/Users/romankiyashev/.electron-gyp/5.0.0-beta.5/include/node/v8.h:2536:17: note: declared here
class V8_EXPORT String : public Name {
                ^
../src/main.cc:61:29: error: use of undeclared identifier 'Handle'
    Handle<String> string = Handle<String>::Cast(info[0]);
                            ^
../src/main.cc:61:45: error: no member named 'Cast' in the global namespace; did you mean 'Just'?
    Handle<String> string = Handle<String>::Cast(info[0]);
                                          ~~^~~~
                                            Just
/Users/romankiyashev/.electron-gyp/5.0.0-beta.5/include/node/v8.h:8831:19: note: 'Just' declared here
  friend Maybe<U> Just(const U& u);
                  ^
../src/main.cc:62:10: error: use of undeclared identifier 'string'
    if (!string->IsString()) {
         ^
../src/main.cc:69:9: error: use of undeclared identifier 'string'
    if (string->Length() == 0) {
        ^
../src/main.cc:73:32: error: use of undeclared identifier 'string'
    std::vector<uint16_t> text(string->Length() + 1);
                               ^
../src/main.cc:74:5: error: use of undeclared identifier 'string'
    string->Write(reinterpret_cast<uint16_t *>(text.data()));
    ^
../src/main.cc:85:25: warning: 'Set' is deprecated: Use maybe version [-Wdeprecated-declarations]
      misspelled_range->Set(Nan::New("start").ToLocalChecked(), Nan::New<Integer>(start));
                        ^
/Users/romankiyashev/.electron-gyp/5.0.0-beta.5/include/node/v8.h:3259:3: note: 'Set' has been explicitly marked deprecated here
  V8_DEPRECATE_SOON("Use maybe version",
  ^
/Users/romankiyashev/.electron-gyp/5.0.0-beta.5/include/node/v8config.h:322:29: note: expanded from macro 'V8_DEPRECATE_SOON'
  declarator __attribute__((deprecated(message)))
                            ^
../src/main.cc:86:25: warning: 'Set' is deprecated: Use maybe version [-Wdeprecated-declarations]
      misspelled_range->Set(Nan::New("end").ToLocalChecked(), Nan::New<Integer>(end));
                        ^
/Users/romankiyashev/.electron-gyp/5.0.0-beta.5/include/node/v8.h:3259:3: note: 'Set' has been explicitly marked deprecated here
  V8_DEPRECATE_SOON("Use maybe version",
  ^
/Users/romankiyashev/.electron-gyp/5.0.0-beta.5/include/node/v8config.h:322:29: note: expanded from macro 'V8_DEPRECATE_SOON'
  declarator __attribute__((deprecated(message)))
                            ^
../src/main.cc:87:15: warning: 'Set' is deprecated: Use maybe version [-Wdeprecated-declarations]
      result->Set(index, misspelled_range);
              ^
/Users/romankiyashev/.electron-gyp/5.0.0-beta.5/include/node/v8.h:3268:3: note: 'Set' has been explicitly marked deprecated here
  V8_DEPRECATE_SOON("Use maybe version",
  ^
/Users/romankiyashev/.electron-gyp/5.0.0-beta.5/include/node/v8config.h:322:29: note: expanded from macro 'V8_DEPRECATE_SOON'
  declarator __attribute__((deprecated(message)))
                            ^
../src/main.cc:97:5: error: use of undeclared identifier 'Handle'; did you mean 'handle'?
    Handle<String> string = Handle<String>::Cast(info[0]);
    ^~~~~~
    handle
../../nan/nan_object_wrap.h:42:32: note: 'handle' declared here
  inline v8::Local<v8::Object> handle() const {
                               ^
../src/main.cc:97:5: error: call to non-static member function without an object argument
    Handle<String> string = Handle<String>::Cast(info[0]);
    ^~~~~~
../src/main.cc:97:12: error: 'String' does not refer to a value
    Handle<String> string = Handle<String>::Cast(info[0]);
           ^
/Users/romankiyashev/.electron-gyp/5.0.0-beta.5/include/node/v8.h:2536:17: note: declared here
class V8_EXPORT String : public Name {
                ^
../src/main.cc:97:20: error: use of undeclared identifier 'string'
    Handle<String> string = Handle<String>::Cast(info[0]);
                   ^
../src/main.cc:97:36: error: 'String' does not refer to a value
    Handle<String> string = Handle<String>::Cast(info[0]);
                                   ^
/Users/romankiyashev/.electron-gyp/5.0.0-beta.5/include/node/v8.h:2536:17: note: declared here
class V8_EXPORT String : public Name {
                ^
../src/main.cc:97:29: error: use of undeclared identifier 'Handle'
    Handle<String> string = Handle<String>::Cast(info[0]);
                            ^
../src/main.cc:97:45: error: no member named 'Cast' in the global namespace; did you mean 'Just'?
    Handle<String> string = Handle<String>::Cast(info[0]);
                                          ~~^~~~
                                            Just
/Users/romankiyashev/.electron-gyp/5.0.0-beta.5/include/node/v8.h:8831:19: note: 'Just' declared here
  friend Maybe<U> Just(const U& u);
                  ^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
19 warnings and 20 errors generated.
make: *** [Release/obj.target/spellchecker/src/main.o] Error 1
gyp ERR! build error 
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/Users/romankiyashev/Documents/Work/maat/node_modules/node-gyp/lib/build.js:262:23)
gyp ERR! stack     at ChildProcess.emit (events.js:182:13)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:240:12)
gyp ERR! System Darwin 18.2.0
gyp ERR! command "/usr/local/lib/node_modules/node/bin/node" "/Users/romankiyashev/Documents/Work/maat/node_modules/electron-rebuild/node_modules/.bin/node-gyp" "rebuild" "--target=5.0.0-beta.5" "--arch=x64" "--dist-url=https://atom.io/download/electron" "--build-from-source"
gyp ERR! cwd /Users/romankiyashev/Documents/Work/maat/node_modules/spellchecker
gyp ERR! node -v v10.10.0
gyp ERR! node-gyp -v v3.8.0
gyp ERR! not ok 

Failed with exit code: 1

Error: gyp info it worked if it ends with ok
gyp info using node-gyp@3.8.0
gyp info using node@10.10.0 | darwin | x64
gyp info spawn /usr/bin/python
gyp info spawn args [ '/Users/romankiyashev/Documents/Work/maat/node_modules/node-gyp/gyp/gyp_main.py',
gyp info spawn args   'binding.gyp',
gyp info spawn args   '-f',
gyp info spawn args   'make',
gyp info spawn args   '-I',
gyp info spawn args   '/Users/romankiyashev/Documents/Work/maat/node_modules/spellchecker/build/config.gypi',
gyp info spawn args   '-I',
gyp info spawn args   '/Users/romankiyashev/Documents/Work/maat/node_modules/node-gyp/addon.gypi',
gyp info spawn args   '-I',
gyp info spawn args   '/Users/romankiyashev/.electron-gyp/5.0.0-beta.5/include/node/common.gypi',
gyp info spawn args   '-Dlibrary=shared_library',
gyp info spawn args   '-Dvisibility=default',
gyp info spawn args   '-Dnode_root_dir=/Users/romankiyashev/.electron-gyp/5.0.0-beta.5',
gyp info spawn args   '-Dnode_gyp_dir=/Users/romankiyashev/Documents/Work/maat/node_modules/node-gyp',
gyp info spawn args   '-Dnode_lib_file=/Users/romankiyashev/.electron-gyp/5.0.0-beta.5/<(target_arch)/node.lib',
gyp info spawn args   '-Dmodule_root_dir=/Users/romankiyashev/Documents/Work/maat/node_modules/spellchecker',
gyp info spawn args   '-Dnode_engine=v8',
gyp info spawn args   '--depth=.',
gyp info spawn args   '--no-parallel',
gyp info spawn args   '--generator-output',
gyp info spawn args   'build',
gyp info spawn args   '-Goutput_dir=.' ]
gyp info spawn make
gyp info spawn args [ 'BUILDTYPE=Release', '-C', 'build' ]
  CXX(target) Release/obj.target/hunspell/vendor/hunspell/src/hunspell/affentry.o
../vendor/hunspell/src/hunspell/affentry.cxx:544:47: warning: while loop has empty body [-Wempty-body]
                        while (p && *p != ']' && (p = nextchar(p)));
                                                                   ^
../vendor/hunspell/src/hunspell/affentry.cxx:544:47: note: put the semicolon on a separate line to silence this warning
1 warning generated.
  CXX(target) Release/obj.target/hunspell/vendor/hunspell/src/hunspell/affixmgr.o
In file included from ../vendor/hunspell/src/hunspell/affixmgr.cxx:12:
../vendor/hunspell/src/hunspell/affentry.hxx:30:105: warning: implicit conversion of NULL constant to 'unsigned short' [-Wnull-conversion]
  struct hentry *      check_twosfx(const char * word, int len, char in_compound, const FLAG needflag = NULL);
                                                                                                      ~ ^~~~
                                                                                                        0
../vendor/hunspell/src/hunspell/affentry.hxx:93:114: warning: implicit conversion of NULL constant to 'unsigned short' [-Wnull-conversion]
  struct hentry *   check_twosfx(const char * word, int len, int optflags, PfxEntry* ppfx, const FLAG needflag = NULL);
                                                                                                               ~ ^~~~
                                                                                                                 0
../vendor/hunspell/src/hunspell/affixmgr.cxx:3654:65: warning: 'strncmp' call operates on objects of type 'const char' while the size is based on a different type 'const char *' [-Wsizeof-pointer-memaccess]
                             if (strncmp(piece, keyword, sizeof(keyword)) != 0) {
                                                ~~~~~~~         ^~~~~~~
../vendor/hunspell/src/hunspell/affixmgr.cxx:3654:65: note: did you mean to provide an explicit length?
                             if (strncmp(piece, keyword, sizeof(keyword)) != 0) {
                                                                ^~~~~~~
3 warnings generated.
  CXX(target) Release/obj.target/hunspell/vendor/hunspell/src/hunspell/csutil.o
  CXX(target) Release/obj.target/hunspell/vendor/hunspell/src/hunspell/dictmgr.o
  CXX(target) Release/obj.target/hunspell/vendor/hunspell/src/hunspell/filemgr.o
  CXX(target) Release/obj.target/hunspell/vendor/hunspell/src/hunspell/hashmgr.o
In file included from ../vendor/hunspell/src/hunspell/hashmgr.cxx:9:
../vendor/hunspell/src/hunspell/hashmgr.hxx:17:21: warning: private field 'userword' is not used [-Wunused-private-field]
  int               userword;
                    ^
1 warning generated.
  CXX(target) Release/obj.target/hunspell/vendor/hunspell/src/hunspell/hunspell.o
  CXX(target) Release/obj.target/hunspell/vendor/hunspell/src/hunspell/hunzip.o
  CXX(target) Release/obj.target/hunspell/vendor/hunspell/src/hunspell/phonet.o
  CXX(target) Release/obj.target/hunspell/vendor/hunspell/src/hunspell/replist.o
  CXX(target) Release/obj.target/hunspell/vendor/hunspell/src/hunspell/suggestmgr.o
  CXX(target) Release/obj.target/hunspell/vendor/hunspell/src/parsers/textparser.o
  LIBTOOL-STATIC Release/hunspell.a
  CXX(target) Release/obj.target/spellchecker/src/main.o
In file included from ../src/main.cc:3:
In file included from ../../nan/nan.h:53:
/Users/romankiyashev/.electron-gyp/5.0.0-beta.5/include/node/node_object_wrap.h:41:25: warning: 'IsNearDeath' is deprecated: Garbage collection internal state should not be relied on. [-Wdeprecated-declarations]
    assert(persistent().IsNearDeath());
                        ^
/Users/romankiyashev/.electron-gyp/5.0.0-beta.5/include/node/v8.h:571:3: note: 'IsNearDeath' has been explicitly marked deprecated here
  V8_DEPRECATE_SOON(
  ^
/Users/romankiyashev/.electron-gyp/5.0.0-beta.5/include/node/v8config.h:322:29: note: expanded from macro 'V8_DEPRECATE_SOON'
  declarator __attribute__((deprecated(message)))
                            ^
In file included from ../src/main.cc:3:
In file included from ../../nan/nan.h:202:
In file included from ../../nan/nan_converters.h:67:
../../nan/nan_converters_43_inl.h:22:1: warning: 'ToBoolean' is deprecated: ToBoolean can never throw. Use Local version. [-Wdeprecated-declarations]
X(Boolean)
^
../../nan/nan_converters_43_inl.h:18:12: note: expanded from macro 'X'
      val->To ## TYPE(isolate->GetCurrentContext())                            \
           ^
<scratch space>:229:1: note: expanded from here
ToBoolean
^
/Users/romankiyashev/.electron-gyp/5.0.0-beta.5/include/node/v8.h:2387:3: note: 'ToBoolean' has been explicitly marked deprecated here
  V8_DEPRECATE_SOON("ToBoolean can never throw. Use Local version.",
  ^
/Users/romankiyashev/.electron-gyp/5.0.0-beta.5/include/node/v8config.h:322:29: note: expanded from macro 'V8_DEPRECATE_SOON'
  declarator __attribute__((deprecated(message)))
                            ^
In file included from ../src/main.cc:3:
In file included from ../../nan/nan.h:202:
In file included from ../../nan/nan_converters.h:67:
../../nan/nan_converters_43_inl.h:40:1: warning: 'BooleanValue' is deprecated: BooleanValue can never throw. Use Isolate version. [-Wdeprecated-declarations]
X(bool, Boolean)
^
../../nan/nan_converters_43_inl.h:37:15: note: expanded from macro 'X'
  return val->NAME ## Value(isolate->GetCurrentContext());                     \
              ^
<scratch space>:236:1: note: expanded from here
BooleanValue
^
/Users/romankiyashev/.electron-gyp/5.0.0-beta.5/include/node/v8.h:2432:3: note: 'BooleanValue' has been explicitly marked deprecated here
  V8_DEPRECATE_SOON("BooleanValue can never throw. Use Isolate version.",
  ^
/Users/romankiyashev/.electron-gyp/5.0.0-beta.5/include/node/v8config.h:322:29: note: expanded from macro 'V8_DEPRECATE_SOON'
  declarator __attribute__((deprecated(message)))
                            ^
In file included from ../src/main.cc:3:
In file included from ../../nan/nan.h:203:
In file included from ../../nan/nan_new.h:189:
../../nan/nan_implementation_12_inl.h:103:37: warning: 'New' is deprecated: Use maybe version [-Wdeprecated-declarations]
  return scope.Escape(v8::Function::New( isolate
                                    ^
/Users/romankiyashev/.electron-gyp/5.0.0-beta.5/include/node/v8.h:4026:10: note: 'New' has been explicitly marked deprecated here
  static V8_DEPRECATED("Use maybe version",
         ^
/Users/romankiyashev/.electron-gyp/5.0.0-beta.5/include/node/v8config.h:307:29: note: expanded from macro 'V8_DEPRECATED'
  declarator __attribute__((deprecated(message)))
                            ^
In file included from ../src/main.cc:3:
In file included from ../../nan/nan.h:203:
In file included from ../../nan/nan_new.h:189:
../../nan/nan_implementation_12_inl.h:337:28: warning: 'New' is deprecated: Use Isolate* version [-Wdeprecated-declarations]
  return v8::StringObject::New(value).As<v8::StringObject>();
                           ^
/Users/romankiyashev/.electron-gyp/5.0.0-beta.5/include/node/v8.h:5313:3: note: 'New' has been explicitly marked deprecated here
  V8_DEPRECATED("Use Isolate* version",
  ^
/Users/romankiyashev/.electron-gyp/5.0.0-beta.5/include/node/v8config.h:307:29: note: expanded from macro 'V8_DEPRECATED'
  declarator __attribute__((deprecated(message)))
                            ^
In file included from ../src/main.cc:3:
../../nan/nan.h:1034:44: warning: 'ToString' is deprecated: Use maybe version [-Wdeprecated-declarations]
      v8::Local<v8::String> string = from->ToString();
                                           ^
/Users/romankiyashev/.electron-gyp/5.0.0-beta.5/include/node/v8.h:2418:10: note: 'ToString' has been explicitly marked deprecated here
  inline V8_DEPRECATED("Use maybe version", Local<String> ToString() const);
         ^
/Users/romankiyashev/.electron-gyp/5.0.0-beta.5/include/node/v8config.h:307:29: note: expanded from macro 'V8_DEPRECATED'
  declarator __attribute__((deprecated(message)))
                            ^
In file included from ../src/main.cc:3:
../../nan/nan.h:1044:27: warning: 'WriteUtf8' is deprecated: Use Isolate* version [-Wdeprecated-declarations]
        length_ = string->WriteUtf8(str_, static_cast<int>(len), 0, flags);
                          ^
/Users/romankiyashev/.electron-gyp/5.0.0-beta.5/include/node/v8.h:2627:3: note: 'WriteUtf8' has been explicitly marked deprecated here
  V8_DEPRECATED("Use Isolate* version",
  ^
/Users/romankiyashev/.electron-gyp/5.0.0-beta.5/include/node/v8config.h:307:29: note: expanded from macro 'V8_DEPRECATED'
  declarator __attribute__((deprecated(message)))
                            ^
In file included from ../src/main.cc:3:
../../nan/nan.h:1818:28: warning: 'Set' is deprecated: Use maybe version [-Wdeprecated-declarations]
    New(persistentHandle)->Set(New(key).ToLocalChecked(), value);
                           ^
/Users/romankiyashev/.electron-gyp/5.0.0-beta.5/include/node/v8.h:3259:3: note: 'Set' has been explicitly marked deprecated here
  V8_DEPRECATE_SOON("Use maybe version",
  ^
/Users/romankiyashev/.electron-gyp/5.0.0-beta.5/include/node/v8config.h:322:29: note: expanded from macro 'V8_DEPRECATE_SOON'
  declarator __attribute__((deprecated(message)))
                            ^
In file included from ../src/main.cc:3:
../../nan/nan.h:1824:28: warning: 'Set' is deprecated: Use maybe version [-Wdeprecated-declarations]
    New(persistentHandle)->Set(key, value);
                           ^
/Users/romankiyashev/.electron-gyp/5.0.0-beta.5/include/node/v8.h:3259:3: note: 'Set' has been explicitly marked deprecated here
  V8_DEPRECATE_SOON("Use maybe version",
  ^
/Users/romankiyashev/.electron-gyp/5.0.0-beta.5/include/node/v8config.h:322:29: note: expanded from macro 'V8_DEPRECATE_SOON'
  declarator __attribute__((deprecated(message)))
                            ^
In file included from ../src/main.cc:3:
../../nan/nan.h:1830:28: warning: 'Set' is deprecated: Use maybe version [-Wdeprecated-declarations]
    New(persistentHandle)->Set(index, value);
                           ^
/Users/romankiyashev/.electron-gyp/5.0.0-beta.5/include/node/v8.h:3268:3: note: 'Set' has been explicitly marked deprecated here
  V8_DEPRECATE_SOON("Use maybe version",
  ^
/Users/romankiyashev/.electron-gyp/5.0.0-beta.5/include/node/v8config.h:322:29: note: expanded from macro 'V8_DEPRECATE_SOON'
  declarator __attribute__((deprecated(message)))
                            ^
In file included from ../src/main.cc:3:
../../nan/nan.h:1836:32: warning: 'Get' is deprecated: Use maybe version [-Wdeprecated-declarations]
        New(persistentHandle)->Get(New(key).ToLocalChecked()));
                               ^
/Users/romankiyashev/.electron-gyp/5.0.0-beta.5/include/node/v8.h:3313:3: note: 'Get' has been explicitly marked deprecated here
  V8_DEPRECATE_SOON("Use maybe version", Local<Value> Get(Local<Value> key));
  ^
/Users/romankiyashev/.electron-gyp/5.0.0-beta.5/include/node/v8config.h:322:29: note: expanded from macro 'V8_DEPRECATE_SOON'
  declarator __attribute__((deprecated(message)))
                            ^
In file included from ../src/main.cc:3:
../../nan/nan.h:1842:48: warning: 'Get' is deprecated: Use maybe version [-Wdeprecated-declarations]
    return scope.Escape(New(persistentHandle)->Get(key));
                                               ^
/Users/romankiyashev/.electron-gyp/5.0.0-beta.5/include/node/v8.h:3313:3: note: 'Get' has been explicitly marked deprecated here
  V8_DEPRECATE_SOON("Use maybe version", Local<Value> Get(Local<Value> key));
  ^
/Users/romankiyashev/.electron-gyp/5.0.0-beta.5/include/node/v8config.h:322:29: note: expanded from macro 'V8_DEPRECATE_SOON'
  declarator __attribute__((deprecated(message)))
                            ^
In file included from ../src/main.cc:3:
../../nan/nan.h:1847:48: warning: 'Get' is deprecated: Use maybe version [-Wdeprecated-declarations]
    return scope.Escape(New(persistentHandle)->Get(index));
                                               ^
/Users/romankiyashev/.electron-gyp/5.0.0-beta.5/include/node/v8.h:3317:3: note: 'Get' has been explicitly marked deprecated here
  V8_DEPRECATE_SOON("Use maybe version", Local<Value> Get(uint32_t index));
  ^
/Users/romankiyashev/.electron-gyp/5.0.0-beta.5/include/node/v8config.h:322:29: note: expanded from macro 'V8_DEPRECATE_SOON'
  declarator __attribute__((deprecated(message)))
                            ^
In file included from ../src/main.cc:3:
In file included from ../../nan/nan.h:2657:
../../nan/nan_object_wrap.h:24:25: warning: 'IsNearDeath' is deprecated: Garbage collection internal state should not be relied on. [-Wdeprecated-declarations]
    assert(persistent().IsNearDeath());
                        ^
/Users/romankiyashev/.electron-gyp/5.0.0-beta.5/include/node/v8.h:571:3: note: 'IsNearDeath' has been explicitly marked deprecated here
  V8_DEPRECATE_SOON(
  ^
/Users/romankiyashev/.electron-gyp/5.0.0-beta.5/include/node/v8config.h:322:29: note: expanded from macro 'V8_DEPRECATE_SOON'
  declarator __attribute__((deprecated(message)))
                            ^
In file included from ../src/main.cc:3:
In file included from ../../nan/nan.h:2657:
../../nan/nan_object_wrap.h:67:18: warning: 'MarkIndependent' is deprecated: Objects are always considered independent. Use MarkActive to avoid collecting otherwise dead weak handles. [-Wdeprecated-declarations]
    persistent().MarkIndependent();
                 ^
/Users/romankiyashev/.electron-gyp/5.0.0-beta.5/include/node/v8.h:553:3: note: 'MarkIndependent' has been explicitly marked deprecated here
  V8_DEPRECATE_SOON(
  ^
/Users/romankiyashev/.electron-gyp/5.0.0-beta.5/include/node/v8config.h:322:29: note: expanded from macro 'V8_DEPRECATE_SOON'
  declarator __attribute__((deprecated(message)))
                            ^
In file included from ../src/main.cc:3:
In file included from ../../nan/nan.h:2657:
../../nan/nan_object_wrap.h:124:26: warning: 'IsNearDeath' is deprecated: Garbage collection internal state should not be relied on. [-Wdeprecated-declarations]
    assert(wrap->handle_.IsNearDeath());
                         ^
/Users/romankiyashev/.electron-gyp/5.0.0-beta.5/include/node/v8.h:571:3: note: 'IsNearDeath' has been explicitly marked deprecated here
  V8_DEPRECATE_SOON(
  ^
/Users/romankiyashev/.electron-gyp/5.0.0-beta.5/include/node/v8config.h:322:29: note: expanded from macro 'V8_DEPRECATE_SOON'
  declarator __attribute__((deprecated(message)))
                            ^
../src/main.cc:195:20: error: no template named 'Handle'
  static void Init(Handle<Object> exports) {
                   ^
../src/main.cc:61:5: error: use of undeclared identifier 'Handle'; did you mean 'handle'?
    Handle<String> string = Handle<String>::Cast(info[0]);
    ^~~~~~
    handle
../../nan/nan_object_wrap.h:42:32: note: 'handle' declared here
  inline v8::Local<v8::Object> handle() const {
                               ^
../src/main.cc:61:5: error: call to non-static member function without an object argument
    Handle<String> string = Handle<String>::Cast(info[0]);
    ^~~~~~
../src/main.cc:61:12: error: 'String' does not refer to a value
    Handle<String> string = Handle<String>::Cast(info[0]);
           ^
/Users/romankiyashev/.electron-gyp/5.0.0-beta.5/include/node/v8.h:2536:17: note: declared here
class V8_EXPORT String : public Name {
                ^
../src/main.cc:61:20: error: use of undeclared identifier 'string'
    Handle<String> string = Handle<String>::Cast(info[0]);
                   ^
../src/main.cc:61:36: error: 'String' does not refer to a value
    Handle<String> string = Handle<String>::Cast(info[0]);
                                   ^
/Users/romankiyashev/.electron-gyp/5.0.0-beta.5/include/node/v8.h:2536:17: note: declared here
class V8_EXPORT String : public Name {
                ^
../src/main.cc:61:29: error: use of undeclared identifier 'Handle'
    Handle<String> string = Handle<String>::Cast(info[0]);
                            ^
../src/main.cc:61:45: error: no member named 'Cast' in the global namespace; did you mean 'Just'?
    Handle<String> string = Handle<String>::Cast(info[0]);
                                          ~~^~~~
                                            Just
/Users/romankiyashev/.electron-gyp/5.0.0-beta.5/include/node/v8.h:8831:19: note: 'Just' declared here
  friend Maybe<U> Just(const U& u);
                  ^
../src/main.cc:62:10: error: use of undeclared identifier 'string'
    if (!string->IsString()) {
         ^
../src/main.cc:69:9: error: use of undeclared identifier 'string'
    if (string->Length() == 0) {
        ^
../src/main.cc:73:32: error: use of undeclared identifier 'string'
    std::vector<uint16_t> text(string->Length() + 1);
                               ^
../src/main.cc:74:5: error: use of undeclared identifier 'string'
    string->Write(reinterpret_cast<uint16_t *>(text.data()));
    ^
../src/main.cc:85:25: warning: 'Set' is deprecated: Use maybe version [-Wdeprecated-declarations]
      misspelled_range->Set(Nan::New("start").ToLocalChecked(), Nan::New<Integer>(start));
                        ^
/Users/romankiyashev/.electron-gyp/5.0.0-beta.5/include/node/v8.h:3259:3: note: 'Set' has been explicitly marked deprecated here
  V8_DEPRECATE_SOON("Use maybe version",
  ^
/Users/romankiyashev/.electron-gyp/5.0.0-beta.5/include/node/v8config.h:322:29: note: expanded from macro 'V8_DEPRECATE_SOON'
  declarator __attribute__((deprecated(message)))
                            ^
../src/main.cc:86:25: warning: 'Set' is deprecated: Use maybe version [-Wdeprecated-declarations]
      misspelled_range->Set(Nan::New("end").ToLocalChecked(), Nan::New<Integer>(end));
                        ^
/Users/romankiyashev/.electron-gyp/5.0.0-beta.5/include/node/v8.h:3259:3: note: 'Set' has been explicitly marked deprecated here
  V8_DEPRECATE_SOON("Use maybe version",
  ^
/Users/romankiyashev/.electron-gyp/5.0.0-beta.5/include/node/v8config.h:322:29: note: expanded from macro 'V8_DEPRECATE_SOON'
  declarator __attribute__((deprecated(message)))
                            ^
../src/main.cc:87:15: warning: 'Set' is deprecated: Use maybe version [-Wdeprecated-declarations]
      result->Set(index, misspelled_range);
              ^
/Users/romankiyashev/.electron-gyp/5.0.0-beta.5/include/node/v8.h:3268:3: note: 'Set' has been explicitly marked deprecated here
  V8_DEPRECATE_SOON("Use maybe version",
  ^
/Users/romankiyashev/.electron-gyp/5.0.0-beta.5/include/node/v8config.h:322:29: note: expanded from macro 'V8_DEPRECATE_SOON'
  declarator __attribute__((deprecated(message)))
                            ^
../src/main.cc:97:5: error: use of undeclared identifier 'Handle'; did you mean 'handle'?
    Handle<String> string = Handle<String>::Cast(info[0]);
    ^~~~~~
    handle
../../nan/nan_object_wrap.h:42:32: note: 'handle' declared here
  inline v8::Local<v8::Object> handle() const {
                               ^
../src/main.cc:97:5: error: call to non-static member function without an object argument
    Handle<String> string = Handle<String>::Cast(info[0]);
    ^~~~~~
../src/main.cc:97:12: error: 'String' does not refer to a value
    Handle<String> string = Handle<String>::Cast(info[0]);
           ^
/Users/romankiyashev/.electron-gyp/5.0.0-beta.5/include/node/v8.h:2536:17: note: declared here
class V8_EXPORT String : public Name {
                ^
../src/main.cc:97:20: error: use of undeclared identifier 'string'
    Handle<String> string = Handle<String>::Cast(info[0]);
                   ^
../src/main.cc:97:36: error: 'String' does not refer to a value
    Handle<String> string = Handle<String>::Cast(info[0]);
                                   ^
/Users/romankiyashev/.electron-gyp/5.0.0-beta.5/include/node/v8.h:2536:17: note: declared here
class V8_EXPORT String : public Name {
                ^
../src/main.cc:97:29: error: use of undeclared identifier 'Handle'
    Handle<String> string = Handle<String>::Cast(info[0]);
                            ^
../src/main.cc:97:45: error: no member named 'Cast' in the global namespace; did you mean 'Just'?
    Handle<String> string = Handle<String>::Cast(info[0]);
                                          ~~^~~~
                                            Just
/Users/romankiyashev/.electron-gyp/5.0.0-beta.5/include/node/v8.h:8831:19: note: 'Just' declared here
  friend Maybe<U> Just(const U& u);
                  ^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
19 warnings and 20 errors generated.
make: *** [Release/obj.target/spellchecker/src/main.o] Error 1
gyp ERR! build error 
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/Users/romankiyashev/Documents/Work/maat/node_modules/node-gyp/lib/build.js:262:23)
gyp ERR! stack     at ChildProcess.emit (events.js:182:13)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:240:12)
gyp ERR! System Darwin 18.2.0
gyp ERR! command "/usr/local/lib/node_modules/node/bin/node" "/Users/romankiyashev/Documents/Work/maat/node_modules/electron-rebuild/node_modules/.bin/node-gyp" "rebuild" "--target=5.0.0-beta.5" "--arch=x64" "--dist-url=https://atom.io/download/electron" "--build-from-source"
gyp ERR! cwd /Users/romankiyashev/Documents/Work/maat/node_modules/spellchecker
gyp ERR! node -v v10.10.0
gyp ERR! node-gyp -v v3.8.0
gyp ERR! not ok 

Failed with exit code: 1
    at SafeSubscriber._error (/Users/romankiyashev/Documents/Work/maat/node_modules/spawn-rx/lib/src/index.js:267:84)
    at SafeSubscriber.__tryOrUnsub (/Users/romankiyashev/Documents/Work/maat/node_modules/spawn-rx/node_modules/rxjs/internal/Subscriber.js:207:16)
    at SafeSubscriber.error (/Users/romankiyashev/Documents/Work/maat/node_modules/spawn-rx/node_modules/rxjs/internal/Subscriber.js:158:26)
    at Subscriber._error (/Users/romankiyashev/Documents/Work/maat/node_modules/spawn-rx/node_modules/rxjs/internal/Subscriber.js:92:26)
    at Subscriber.error (/Users/romankiyashev/Documents/Work/maat/node_modules/spawn-rx/node_modules/rxjs/internal/Subscriber.js:72:18)
    at MapSubscriber.Subscriber._error (/Users/romankiyashev/Documents/Work/maat/node_modules/spawn-rx/node_modules/rxjs/internal/Subscriber.js:92:26)
    at MapSubscriber.Subscriber.error (/Users/romankiyashev/Documents/Work/maat/node_modules/spawn-rx/node_modules/rxjs/internal/Subscriber.js:72:18)
    at SafeSubscriber._next (/Users/romankiyashev/Documents/Work/maat/node_modules/spawn-rx/lib/src/index.js:242:65)
    at SafeSubscriber.__tryOrUnsub (/Users/romankiyashev/Documents/Work/maat/node_modules/spawn-rx/node_modules/rxjs/internal/Subscriber.js:207:16)
    at SafeSubscriber.next (/Users/romankiyashev/Documents/Work/maat/node_modules/spawn-rx/node_modules/rxjs/internal/Subscriber.js:145:22)
ghost commented 5 years ago

Same for 5.0.0-beta.7. Any chance to get working version before electron 5.x will be released (target is April 23)?

AlexandreKilian commented 5 years ago

same for electron 4.1 :(

AlexandreKilian commented 5 years ago

I fixed it by rebuilding the module: https://electronjs.org/docs/tutorial/using-native-node-modules

ghost commented 5 years ago

@AlexandreKilian I guess you fixed it for electron 4.1.x. Right?

For version 5.x.x it won't work. Module itself contain V8::Handle, that was deprecated. There is simple change needed to make it work and I believe electron team aware of it. See: https://electronjs.org/blog/nodejs-native-addons-and-electron-5

AlexandreKilian commented 5 years ago

yes, sorry, for 4.1.x

ghost commented 5 years ago

@nathansobo any chance to resolve issue with deprecated methods? Electron 5 already released.

nathansobo commented 5 years ago

We ourselves are behind on Electron versions and somewhat overwhelmed with other tasks. If someone wants to open a PR I'll review it, otherwise we'll get to this when we have bandwidth.

ghost commented 5 years ago

@nathansobo pull request is already exist: https://github.com/atom/node-spellchecker/pull/108