Fix builds with newer node.

atom / node-spellchecker

SpellChecker Node Module

http://atom.github.io/node-spellchecker

MIT License

300 stars 108 forks source link

Fix builds with newer node. #122

Closed goddessfreya closed 5 years ago

goddessfreya commented 5 years ago

As part of my quest to add spell checking to riot (https://github.com/vector-im/riot-web/issues/2661), first this package needs to compile.

Signed-off-by: Hal Gentz zegentzy@protonmail.com

rafeca commented 5 years ago

Thanks for the PR! I've added a couple of commits to it to try to get a green build.

Basically, I've added back support to Node v8 since it's too early to drop support to it for Atom (Atom just moved to Node v10 last week so in case we need to revert back Node v8 we want this module to keep working 😄).

Once/if the CI builds are green I'll merge this one and publish a new version of the package.