search

atom / node-spellchecker

SpellChecker Node Module
http://atom.github.io/node-spellchecker
MIT License
300 stars 108 forks source link

Prebuild binaries #126

Closed bendemboski closed 5 years ago

bendemboski commented 5 years ago

Use prebuild and prebuild-install to enable consumption of prebuilt binaries. This is basically a copy of how node-keytar does it

rsese commented 5 years ago

Thanks for the contribution! Chatted with the other maintainers and while we do see that prebuilt binaries could be generally useful for other applications that use node-spellchecker, it doesn't look like something necessary for Atom in particular (let me know if I'm misunderstanding though). With our current resources and priorities, as much as possible we're not taking on changes that don't directly address some issue/bug in Atom. node-keytar is a bit different right now because it has someone keeping an eye on it consistently.

If things change in the future we could revisit this but for now, because we treat our issues list as the Atom team's backlog, we'll close this out since it's not something the team would work on. But thank you again for the contribution, we do appreciate it.